reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186783570
########## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ########## @@ -10,3 +10,15 @@ org.apache.flink.connector.pulsar.source.PulsarSourceITCase does not satisfy: on * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\ * reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule +org.apache.flink.connector.pulsar.sink.PulsarSinkITCase does not satisfy: only one of the following predicates match:\ Review Comment: > I guess the violation in PulsarSinkITCase caused by non static field private final MiniClusterExtension. After testing, I found that this guess is incorrect. The real reason is that the top level class must have a qualified mini cluster field and the nested classes are not considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
