zentol commented on code in PR #22520:
URL: https://github.com/apache/flink/pull/22520#discussion_r1187264449
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -475,6 +477,11 @@ public boolean isChainingEnabled() {
return isChainingEnabled;
}
+ @PublicEvolving
+ public boolean
isChainingOfOperatorsWithDifferentMaxParallelismEnabledEnabled() {
Review Comment:
Not sure if we need really this method though, but I can see it's value
w.r.t. consistent configuration.
(although it would be great if we would consolidate all these setters into
some pojo, instead of having to modify the StreamExEnv whenever we expose
another thing).
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -475,6 +477,11 @@ public boolean isChainingEnabled() {
return isChainingEnabled;
}
+ @PublicEvolving
+ public boolean
isChainingOfOperatorsWithDifferentMaxParallelismEnabledEnabled() {
Review Comment:
```suggestion
public boolean isChainingOfOperatorsWithDifferentMaxParallelismEnabled()
{
```
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -475,6 +477,11 @@ public boolean isChainingEnabled() {
return isChainingEnabled;
}
+ @PublicEvolving
+ public boolean
isChainingOfOperatorsWithDifferentMaxParallelismEnabledEnabled() {
Review Comment:
You will also have to extend the Scala API if you're adding a method here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
