Myasuka commented on code in PR #22458:
URL: https://github.com/apache/flink/pull/22458#discussion_r1187314041
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java:
##########
@@ -82,34 +88,42 @@ public final class RocksDBResourceContainer implements
AutoCloseable {
@VisibleForTesting
public RocksDBResourceContainer() {
- this(new Configuration(), PredefinedOptions.DEFAULT, null, null,
false);
+ this(new Configuration(), PredefinedOptions.DEFAULT, null, null, null,
false);
}
@VisibleForTesting
public RocksDBResourceContainer(
PredefinedOptions predefinedOptions, @Nullable
RocksDBOptionsFactory optionsFactory) {
- this(new Configuration(), predefinedOptions, optionsFactory, null,
false);
+ this(new Configuration(), predefinedOptions, optionsFactory, null,
null, false);
}
@VisibleForTesting
public RocksDBResourceContainer(
PredefinedOptions predefinedOptions,
@Nullable RocksDBOptionsFactory optionsFactory,
@Nullable OpaqueMemoryResource<RocksDBSharedResources>
sharedResources) {
- this(new Configuration(), predefinedOptions, optionsFactory,
sharedResources, false);
+ this(new Configuration(), predefinedOptions, optionsFactory,
sharedResources, null, false);
}
public RocksDBResourceContainer(
Review Comment:
If you want to fix this bug on older versions, please keep the previous
interface and introduce another package-private interface with
`instanceBasePath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
