[
https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595767#comment-15595767
]
ASF GitHub Bot commented on FLINK-4204:
---------------------------------------
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2670
I pushed a commit to remove the `GraphMetrics` example.
I think providing drivers for all library methods is both desirable and
ambitious. If we like the form and functionality of the current drivers then
I'd like to look at consolidating common functionality where possible. We may
also be able to put multiple similar algorithms like `JaccardIndex` /
`AdamicAdar` / `CommonNeighbors` into the same driver.
I had first removed `TriangleListing` as it's not an algorithm but I added
it back due to Facebook's recent benchmarking:
https://code.facebook.com/posts/319004238457019/a-comparison-of-state-of-the-art-graph-processing-systems
> Clean up gelly-examples
> -----------------------
>
> Key: FLINK-4204
> URL: https://issues.apache.org/jira/browse/FLINK-4204
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Greg Hogan
>
> The gelly-examples has grown quite big (14 examples) and contains several
> examples that illustrate the same functionality. Examples should help users
> understand how to use the API and ideally show how to use 1-2 features.
> Also, it is helpful to state the purpose of each example in the comments.
> We should keep the example set small and move everything that does not fit
> there to the library.
> I propose to remove the following:
> - ClusteringCoefficient: the functionality already exists as a library method.
> - HITS: the functionality already exists as a library method.
> - JaccardIndex: the functionality already exists as a library method.
> - SingleSourceShortestPaths: the example shows how to use scatter-gather
> iterations. HITSAlgorithm shows the same feature plus the use of aggregators.
> I propose we keep this one instead.
> - TriangleListing: the functionality already exists as a library method
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)