mateczagany commented on PR #587: URL: https://github.com/apache/flink-kubernetes-operator/pull/587#issuecomment-1540221341
I thought this test case was covered by the end-to-end tests. I wanted to make sure that the user won't accidentally make changes to the Kubernetes cluster that is defined in `~/.kube/config` by simply running the tests, and this test case does exactly that. I know that it would require to specifically set `it.skip` to false, but removing this test allowed me to remove minikube from the CI step to make sure all new tests added in the future will not accidentally make changes to the users Kubernetes server. I have some other solutions in mind if the current solution does not seem fine: - Restore `FlinkOperatorITCase.java` and run this test in the e2e job of the CI workflow - Restore `FlinkOperatorITCase.java` and revert changes to `ci.yml` but then we risk adding tests in the future that make changes to the users Kubernetes server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
