libenchao commented on code in PR #22533:
URL: https://github.com/apache/flink/pull/22533#discussion_r1189370293
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java:
##########
@@ -46,7 +46,7 @@ static Executor create(
*
* @return the session configuration.
*/
- ReadableConfig getSessionConfig();
+ Map<String, String> getSessionConfig();
Review Comment:
Is this a public api? Although this is not clearly annotated as 'api', we
may need to be careful about this change. CC @fsk119 what do you think about
this since you are the original author of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
