zentol commented on code in PR #22548:
URL: https://github.com/apache/flink/pull/22548#discussion_r1189890956


##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java:
##########
@@ -47,8 +58,26 @@ public T getExecutor() {
 
     @Override
     public void afterAll(ExtensionContext context) throws Exception {
+        gracefulShutdown(executorService, LOG);
+    }
+
+    static void gracefulShutdown(@Nullable ExecutorService executorService, 
Logger logger) {

Review Comment:
   > failing with an AssertionError if there are still Runnables that have been 
processed by the executor
   
   That'd be quite annoying when using a scheduled executor service, no? That 
will some send a runnable at some point in the future.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to