XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190878579
##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
<flink.reuseForks>true</flink.reuseForks>
<flink.surefire.baseArgLine>-XX:+UseG1GC
-Xms256m</flink.surefire.baseArgLine>
- <flink.shaded.version>16.1</flink.shaded.version>
-
<flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>
Review Comment:
No, I suggest updating to Curator 5.4.0 because that's what we're using in
flink-shaded 17.0. AFAIR, there was only one code location that needs to be
updated in
[ZooKeeperTestUtils:57](https://github.com/apache/flink/blob/e122dec43edac9a03ef86eeacd02ebb5f429eb70/flink-runtime/src/test/java/org/apache/flink/runtime/testutils/ZooKeeperTestUtils.java#L57).
The Integer value needs to be changed to a String (`60_000` becomes `"60000"`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
