LadyForest commented on code in PR #22539:
URL: https://github.com/apache/flink/pull/22539#discussion_r1191301752
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/CompiledPlan.java:
##########
@@ -109,6 +109,8 @@ default void writeToFile(File file) {
*/
void writeToFile(File file, boolean ignoreIfExists);
+ void writeToFile(org.apache.flink.core.fs.Path path, boolean
ignoreIfExists);
Review Comment:
I think there's no need to add an extra interface method to achieve the goal.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/InternalPlan.java:
##########
@@ -44,6 +45,13 @@ public interface InternalPlan {
*/
void writeToFile(File file, boolean ignoreIfExists, boolean failIfExists);
+ /**
+ * Note that {@code ignoreIfExists} has precedence over {@code
failIfExists}.
+ *
+ * @see CompiledPlan#writeToFile(Path, boolean)
+ */
+ void writeToFile(Path path, boolean ignoreIfExists, boolean failIfExists);
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
