snuyanzin commented on code in PR #22574:
URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala:
##########
@@ -32,12 +35,11 @@ class FileSystemTestCsvITCase extends
BatchFileSystemITCaseBase {
override def getScheme: String = "test"
- @After
+ @AfterEach
def close(): Unit = {
val path = new Path(resultPath)
- assertEquals(
- s"File $resultPath is not closed",
- 0,
- TestFileSystem.getNumberOfUnclosedOutputStream(path))
+ if (TestFileSystem.getNumberOfUnclosedOutputStream(path) != 0) {
+ Assertions.fail(s"File $resultPath is not closed");
+ }
Review Comment:
yeah.. that's weird...
there is WA for that
```scala
assertThat(TestFileSystem.getNumberOfUnclosedOutputStream(path))
.as(s"File $resultPath is not closed")
.asInstanceOf[AbstractIntegerAssert[_]]
.isEqualTo(0)
```
however there is an issue with such WA: in case there is more than one such
WA per class it leads to issues for IntellijIdea (mvn works fine)...
I've filed scala plugin issue https://youtrack.jetbrains.com/issue/SCL-20679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
