RamanVerma commented on code in PR #29:
URL:
https://github.com/apache/flink-connector-kafka/pull/29#discussion_r1194444366
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/initializer/SpecifiedOffsetsInitializer.java:
##########
@@ -38,6 +38,10 @@
* An implementation of {@link OffsetsInitializer} which initializes the
offsets of the partition
* according to the user specified offsets.
*
+ * <p>Use specified offsets for specified partitions while use commit offsets
or earliest for
Review Comment:
@loserwang1024 I have a question.
When you mention `specified offsets`, do you mean the ones provided in the
map `initialOffsets`.
If that is true, these unspecified partitions are initialized to be consumed
according to `offsetResetStrategy`, which can be `earliest` or `latest`. So,
not necessarily `earliest`
Also, could you point me to the code (or code change) that explains this
> Specified partition's offset should be less than its latest offset,
otherwise it will start from the earliest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
