hlteoh37 commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1194739601
########## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/SourceConfigConstants.java: ########## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kinesis.source.config; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.connector.aws.config.AWSConfigConstants; +import org.apache.flink.connector.kinesis.source.reader.PollingKinesisShardSplitReader; + +import java.time.Duration; + +/** Constants to be used with the KinesisStreamsSource. */ +@Experimental +public class SourceConfigConstants extends AWSConfigConstants { + /** Marks the initial position to use when reading from the Kinesis stream. */ + public enum InitialPosition { + LATEST, + TRIM_HORIZON, + AT_TIMESTAMP + } + + /** The record publisher type represents the record-consume style. */ + public enum RecordPublisherType { + + /** Consume the Kinesis records using AWS SDK v2 with the enhanced fan-out consumer. */ + EFO, + /** Consume the Kinesis records using AWS SDK v1 with the get-records method. */ + POLLING + } + + /** The EFO registration type represents how we are going to de-/register efo consumer. */ + public enum EFORegistrationType { + + /** + * Delay the registration of efo consumer for taskmanager to execute. De-register the efo + * consumer for taskmanager to execute when task is shut down. + */ + LAZY, + /** + * Register the efo consumer eagerly for jobmanager to execute. De-register the efo consumer + * the same way as lazy does. + */ + EAGER, + /** Do not register efo consumer programmatically. Do not de-register either. */ + NONE + } + + /** The RecordPublisher type (EFO|POLLING). */ + public static final String RECORD_PUBLISHER_TYPE = "flink.stream.recordpublisher"; Review Comment: Thats a great callout. I had thought that was weird too... At the moment, we just copy from the previous connector. I wanted to rename these configs as part of this JIRA https://issues.apache.org/jira/browse/FLINK-31990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
