reswqa commented on code in PR #22246:
URL: https://github.com/apache/flink/pull/22246#discussion_r1194839931
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskExecutorManagerTest.java:
##########
@@ -176,22 +170,25 @@ public void testTaskManagerTimeoutDoesNotRemoveSlots()
throws Exception {
InstanceID newTaskExecutorId =
createAndRegisterTaskExecutor(
taskExecutorManager, 1,
ResourceProfile.ANY);
- assertEquals(1,
taskExecutorManager.getNumberRegisteredSlots());
+
assertThat(taskExecutorManager.getNumberRegisteredSlots())
+ .isEqualTo(1);
return newTaskExecutorId;
},
mainThreadExecutor)
// wait for the timeout to occur
.thenCombine(
releaseResourceFuture,
(registeredInstance, releasedInstance) -> {
- assertThat(registeredInstance,
is(releasedInstance));
- assertEquals(1,
taskExecutorManager.getNumberRegisteredSlots());
+
assertThat(registeredInstance).isEqualTo(releasedInstance);
+
assertThat(taskExecutorManager.getNumberRegisteredSlots())
+ .isEqualTo(1);
return registeredInstance;
})
.thenAccept(
taskExecutorId -> {
taskExecutorManager.unregisterTaskExecutor(taskExecutorId);
- assertEquals(0,
taskExecutorManager.getNumberRegisteredSlots());
+
assertThat(taskExecutorManager.getNumberRegisteredSlots())
+ .isEqualTo(0);
Review Comment:
`isZero()`
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskExecutorManagerTest.java:
##########
@@ -46,22 +45,18 @@
import java.util.stream.Collectors;
import java.util.stream.IntStream;
-import static org.hamcrest.Matchers.equalTo;
-import static org.hamcrest.Matchers.is;
-import static org.hamcrest.Matchers.nullValue;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
/** Tests for the {@link TaskExecutorManager}. */
-public class TaskExecutorManagerTest extends TestLogger {
+public class TaskExecutorManagerTest {
Review Comment:
Maybe package private?
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskExecutorManagerTest.java:
##########
@@ -213,19 +210,17 @@ public void testTimeoutForUnusedTaskManager() throws
Exception {
new TestingResourceAllocatorBuilder()
.setDeclareResourceNeededConsumer(
(resourceDeclarations) -> {
- assertThat(resourceDeclarations.size(),
is(1));
+
assertThat(resourceDeclarations.size()).isEqualTo(1);
ResourceDeclaration resourceDeclaration =
resourceDeclarations.iterator().next();
if (declareResourceCount.getAndIncrement()
== 0) {
-
assertThat(resourceDeclaration.getNumNeeded(), is(1));
- assertThat(
-
resourceDeclaration.getUnwantedWorkers().size(),
- is(0));
+
assertThat(resourceDeclaration.getNumNeeded()).isEqualTo(1);
+
assertThat(resourceDeclaration.getUnwantedWorkers())
+ .isEmpty();
} else {
-
assertThat(resourceDeclaration.getNumNeeded(), is(0));
- assertThat(
-
resourceDeclaration.getUnwantedWorkers().size(),
- is(1));
+
assertThat(resourceDeclaration.getNumNeeded()).isEqualTo(0);
Review Comment:
`isZero()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
