afedulov commented on code in PR #22556:
URL: https://github.com/apache/flink/pull/22556#discussion_r1195128365
##########
flink-core/src/main/java/org/apache/flink/util/NetUtils.java:
##########
@@ -120,6 +120,18 @@ private static URL validateHostPortString(String hostPort)
{
}
}
+ /**
+ * Converts an InetSocketAddress to a URL. This method assigns the
"http://"; schema to the URL
Review Comment:
Good question! The current `RestClient` does nots support the concept of a
scheme. The low-level SSL context is setup separately based on the Flink config
https://github.com/apache/flink/blob/451c8f2014d4043cb3d4ad31124c4bbb748315a6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java#L156
and the request methods just work with a host and a port:
https://github.com/apache/flink/blob/451c8f2014d4043cb3d4ad31124c4bbb748315a6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java#L326-L327
Existing users can continue using SSL by specifying `foo.com:443` and
setting `security.ssl.rest.enabled: true` in their local flink-cong.yaml. In
the upcoming "https" support PR I plan to remove the requirement to edit
flink-conf.yaml and configure SSL dynamically instead.
##########
flink-core/src/main/java/org/apache/flink/util/NetUtils.java:
##########
@@ -120,6 +120,18 @@ private static URL validateHostPortString(String hostPort)
{
}
}
+ /**
+ * Converts an InetSocketAddress to a URL. This method assigns the
"http://"; schema to the URL
Review Comment:
Good question! The current `RestClient` does nots support the concept of a
scheme. The low-level SSL context is setup separately based on the Flink config
https://github.com/apache/flink/blob/451c8f2014d4043cb3d4ad31124c4bbb748315a6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java#L156
and the request methods just work with a host and a port:
https://github.com/apache/flink/blob/451c8f2014d4043cb3d4ad31124c4bbb748315a6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java#L326-L327
Existing users can continue using SSL by specifying `foo.com:443` and
setting `security.ssl.rest.enabled: true` in their local flink-conf.yaml. In
the upcoming "https" support PR I plan to remove the requirement to edit
flink-conf.yaml and configure SSL dynamically instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
