dmvk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1195425478
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java:
##########
@@ -39,6 +44,10 @@ public class ErrorInfo implements Serializable {
private final long timestamp;
+ private final transient CompletableFuture<Map<String, String>>
labelsFuture;
+ /** Labels associated with the exception, set as soon as labelsFuture is
completed. */
+ private Map<String, String> labels;
Review Comment:
haha, this seems to go against
https://github.com/apache/flink/pull/22506#discussion_r1192155460
I guess it's a matter of taste, your call. We have to avoid blocking in both
cases (which is what @zhuzhurk's comment seems to be mostly about).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
