1996fanrui commented on code in PR #22560:
URL: https://github.com/apache/flink/pull/22560#discussion_r1195929472
##########
flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java:
##########
@@ -92,6 +92,17 @@ public class ExecutionOptions {
.withDescription(
"Tells if we should use compression for the state
snapshot data or not");
+ public static final ConfigOption<Boolean> BUFFER_TIMEOUT_ENABLED =
+ ConfigOptions.key("execution.buffer-timeout.enabled")
Review Comment:
Hi @Myracle , thanks for your feedback.
I see too many related option names that all have the same prefix but
different suffixes. From the user's point of view, the same prefix also clearly
tells the user that these options are related. Therefore, when FLINK-29372
restricts the option prefix, it also adds suffixes to many option names that do
not conform to the specification.
So I prefer keep the prefixes the same for these 2 options. In order to the
reasonable of this fix, I look forward to more feedback from community.
Hi @wanglijie95 @reswqa , would you mind take a look this PR in your free
time? thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
