reswqa commented on PR #22598: URL: https://github.com/apache/flink/pull/22598#issuecomment-1550891177
> There's a risk that @EnabledIf is missed when adding a new test. Yes, that's also why I introduced the assertion check in `checkAndSetKubeConfigFile` to fast-fail this if `@EnabledIf` is missed. Without considering complexity, we can even perform static code checks on this, maybe something like `ITCaseRules`. I even have some doubts about whether the use of `KubernetesExtension` is discouraged by `Junt`. IIUC, the idea of the `Junit` framework is that we need to decide whether to skip tests based on conditions, rather than using certain extensions based on conditions, so it did not provide good support for this pattern. > I'm wondering whether we should keep it like it is if there's no way to fix it within KubernetesExtension. If we keep it as it is, there doesn't seem to be much of a problem. So, I don't have a particularly strong tendency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
