pgaref commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1198145131
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/RootExceptionHistoryEntry.java:
##########
@@ -107,26 +121,33 @@ public static RootExceptionHistoryEntry
fromExceptionHistoryEntry(
public static RootExceptionHistoryEntry fromGlobalFailure(ErrorInfo
errorInfo) {
Preconditions.checkNotNull(errorInfo, "errorInfo");
return fromGlobalFailure(
- errorInfo.getException(), errorInfo.getTimestamp(),
Collections.emptyList());
+ errorInfo.getException(),
+ errorInfo.getTimestamp(),
+ FailureEnricherUtils.EMPTY_FAILURE_LABELS,
+ Collections.emptyList());
}
private static RootExceptionHistoryEntry createRootExceptionHistoryEntry(
Throwable cause,
long timestamp,
+ CompletableFuture<Map<String, String>> failureLabels,
@Nullable String failingTaskName,
@Nullable TaskManagerLocation taskManagerLocation,
Iterable<Execution> executions) {
return new RootExceptionHistoryEntry(
cause,
timestamp,
+ failureLabels,
failingTaskName,
taskManagerLocation,
StreamSupport.stream(executions.spliterator(), false)
.filter(execution ->
execution.getFailureInfo().isPresent())
.map(
execution ->
ExceptionHistoryEntry.create(
- execution,
execution.getVertexWithAttempt()))
+ execution,
+
execution.getVertexWithAttempt(),
+ failureLabels))
Review Comment:
Thanks both! Sure, changed to `EMPTY_FAILURE_LABELS`
Labels are currently part of `ExceptionHistoryEntry` -- lets think about
moving them upas part of the Rest Api ticket.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/RootExceptionHistoryEntry.java:
##########
@@ -107,26 +121,33 @@ public static RootExceptionHistoryEntry
fromExceptionHistoryEntry(
public static RootExceptionHistoryEntry fromGlobalFailure(ErrorInfo
errorInfo) {
Preconditions.checkNotNull(errorInfo, "errorInfo");
return fromGlobalFailure(
- errorInfo.getException(), errorInfo.getTimestamp(),
Collections.emptyList());
+ errorInfo.getException(),
+ errorInfo.getTimestamp(),
+ FailureEnricherUtils.EMPTY_FAILURE_LABELS,
+ Collections.emptyList());
}
private static RootExceptionHistoryEntry createRootExceptionHistoryEntry(
Throwable cause,
long timestamp,
+ CompletableFuture<Map<String, String>> failureLabels,
@Nullable String failingTaskName,
@Nullable TaskManagerLocation taskManagerLocation,
Iterable<Execution> executions) {
return new RootExceptionHistoryEntry(
cause,
timestamp,
+ failureLabels,
failingTaskName,
taskManagerLocation,
StreamSupport.stream(executions.spliterator(), false)
.filter(execution ->
execution.getFailureInfo().isPresent())
.map(
execution ->
ExceptionHistoryEntry.create(
- execution,
execution.getVertexWithAttempt()))
+ execution,
+
execution.getVertexWithAttempt(),
+ failureLabels))
Review Comment:
Thanks both! Sure, changed to `EMPTY_FAILURE_LABELS`
Labels are currently part of `ExceptionHistoryEntry` -- lets think about
moving them as part of the Rest Api ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
