[
https://issues.apache.org/jira/browse/FLINK-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601578#comment-15601578
]
ASF GitHub Bot commented on FLINK-4639:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2521#discussion_r84659763
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/CalciteConfig.scala
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.table
+
+import org.apache.calcite.sql.SqlOperatorTable
+import org.apache.calcite.sql.parser.SqlParser
+import org.apache.calcite.tools.RuleSet
+import org.apache.flink.util.Preconditions
+
+/**
+ * Builder for creating a Calcite configuration.
+ */
+class CalciteConfigBuilder {
+ private var replaceRuleSet: Option[RuleSet] = None
+ private var chainRuleSet: Option[RuleSet] = None
+
+ private var replaceSqlOperatorTable: Option[SqlOperatorTable] = None
+ private var chainSqlOperatorTable: Option[SqlOperatorTable] = None
+
+ private var replaceSqlParserConfig: Option[SqlParser.Config] = None
+
+ /**
+ * Replaces the built-in rule set with the given rule set.
+ */
+ def replaceRuleSet(ruleSet: RuleSet): CalciteConfigBuilder = {
+ Preconditions.checkNotNull(ruleSet)
+ replaceRuleSet = Some(ruleSet)
+ chainRuleSet = None
+ this
+ }
+
+ /**
+ * Appends the given rule set to the built-in rule set.
+ */
+ def addRuleSet(ruleSet: RuleSet): CalciteConfigBuilder = {
+ Preconditions.checkNotNull(ruleSet)
+ replaceRuleSet = None
+ chainRuleSet = Some(ruleSet)
+ this
+ }
+
+ /**
+ * Replaces the built-in SQL operator table with the given table.
+ */
+ def replaceSqlOperatorTable(sqlOperatorTable: SqlOperatorTable):
CalciteConfigBuilder = {
+ Preconditions.checkNotNull(sqlOperatorTable)
+ replaceSqlOperatorTable = Some(sqlOperatorTable)
+ chainSqlOperatorTable = None
+ this
+ }
+
+ /**
+ * Appends the given table to the built-in SQL operator table.
+ */
+ def addSqlOperatorTable(sqlOperatorTable: SqlOperatorTable):
CalciteConfigBuilder = {
+ Preconditions.checkNotNull(sqlOperatorTable)
+ replaceSqlOperatorTable = None
+ chainSqlOperatorTable = Some(sqlOperatorTable)
--- End diff --
operator table would be replaced and not added if `addSqlOperatorTable` is
called twice.
> Make Calcite features more pluggable
> ------------------------------------
>
> Key: FLINK-4639
> URL: https://issues.apache.org/jira/browse/FLINK-4639
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> Some users might want to extend the feature set of the Table API by adding or
> replacing Calcite optimizer rules, modifying the parser etc. It would be good
> to have means to hook into the Table API and change Calcite behavior. We
> should implement something like a {{CalciteConfigBuilder}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
