zentol commented on code in PR #22390:
URL: https://github.com/apache/flink/pull/22390#discussion_r1200368122
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerServiceImplTest.java:
##########
@@ -79,6 +80,8 @@ public class ResourceManagerServiceImplTest extends
TestLogger {
private TestingResourceManagerFactory.Builder rmFactoryBuilder;
private TestingLeaderElectionService leaderElectionService;
+ private LeaderElection leaderElection;
Review Comment:
:thinking:
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerServiceImplTest.java:
##########
@@ -105,17 +108,15 @@ public void teardown() throws Exception {
resourceManagerService.close();
}
- if (leaderElectionService != null) {
- leaderElectionService.stop();
- }
-
if (fatalErrorHandler.hasExceptionOccurred()) {
fatalErrorHandler.rethrowError();
}
}
@AfterClass
public static void teardownClass() throws Exception {
+ haService.closeAndCleanupAllData();
Review Comment:
This is required because we dont have access to the created
`LeaderElection`? Shouldn't this use
`TestingLeaderElectionService#triggerContenderCleanup`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
