XComp commented on code in PR #22390:
URL: https://github.com/apache/flink/pull/22390#discussion_r1200741844
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerServiceImplTest.java:
##########
@@ -105,17 +108,15 @@ public void teardown() throws Exception {
resourceManagerService.close();
}
- if (leaderElectionService != null) {
- leaderElectionService.stop();
- }
-
if (fatalErrorHandler.hasExceptionOccurred()) {
fatalErrorHandler.rethrowError();
}
}
@AfterClass
public static void teardownClass() throws Exception {
+ haService.closeAndCleanupAllData();
Review Comment:
tbh I don't know anymore why I added this. The haServices are testing
implementations anyway. The LeaderElection will be cleaned up through the
`ResourceManagerServiceImpl.close()` call in [line
108](https://github.com/XComp/flink/blob/FLINK-31785/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerServiceImplTest.java#L108)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
