snuyanzin commented on code in PR #22324:
URL: https://github.com/apache/flink/pull/22324#discussion_r1201632409


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -435,6 +435,16 @@ public class ExecutionConfigOptions {
                             "Determines whether CAST will operate following 
the legacy behaviour "
                                     + "or the new one that introduces various 
fixes and improvements.");
 
+    @Documentation.TableOption(execMode = 
Documentation.ExecMode.BATCH_STREAMING)
+    public static final ConfigOption<MapKeyDedupPolicy> 
TABLE_EXEC_MAPKEY_DEDUP_POLICY =
+            key("table.exec.mapkey-dedup-policy")

Review Comment:
   besides `map_from_array` there are others, e.g. `map` constructor
   different ways of casting e.g. 
   ```sql
   select cast(map['1', '2', ' 1', '2'] as map<int,int>);
   ```
   
   it looks like a major change and probably makes sense to discuss it first 
rather to make it silently (e.g. there is nothing about that in corresponding 
JIRA issue)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to