snuyanzin commented on code in PR #22558:
URL: https://github.com/apache/flink/pull/22558#discussion_r1190413352


##########
flink-table/flink-sql-jdbc-driver/pom.xml:
##########
@@ -84,6 +84,12 @@
                        <version>${project.version}</version>
                        <scope>test</scope>
                </dependency>
+               <dependency>
+                       <groupId>com.google.guava</groupId>
+                       <artifactId>guava</artifactId>
+                       <version>${guava.version}</version>
+                       <scope>provided</scope>
+               </dependency>

Review Comment:
   Suddenly with Calcite 1.31.0 it starts failing with guava's 
`ImmutableList/Map` not found. 
   like 
   ```
   Caused by: java.lang.NoClassDefFoundError: 
com/google/common/collect/ImmutableMap
        at 
org.apache.flink.sql.parser.impl.FlinkSqlParserImpl.setTimeUnitCodes(FlinkSqlParserImpl.java:296)
        at org.apache.calcite.sql.parser.SqlParser.<init>(SqlParser.java:73)
        at org.apache.calcite.sql.parser.SqlParser.create(SqlParser.java:126)
        at org.apache.calcite.sql.parser.SqlParser.create(SqlParser.java:105)
        at 
org.apache.flink.table.planner.parse.CalciteParser.parseSqlList(CalciteParser.java:75)
        at 
org.apache.flink.table.planner.delegation.ParserImpl.parse(ParserImpl.java:102)
        at 
org.apache.flink.table.gateway.service.operation.OperationExecutor.executeStatement(OperationExecutor.java:186)
        at 
org.apache.flink.table.gateway.service.SqlGatewayServiceImpl.lambda$executeStatement$1(SqlGatewayServiceImpl.java:212)
        at 
org.apache.flink.table.gateway.service.operation.OperationManager.lambda$submitOperation$1(OperationManager.java:119)
        at 
org.apache.flink.table.gateway.service.operation.OperationManager$Operation.lambda$run$0(OperationManager.java:258)
        ... 7 more
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to