gyfora commented on code in PR #604:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/604#discussion_r1203790510
##########
helm/flink-kubernetes-operator/templates/rbac.yaml:
##########
@@ -71,13 +71,18 @@ rules:
- ingresses
verbs:
- "*"
+{{/*
+watchNamespaces doesn't need this since the operator handles it
+*/}}
+{{- if not .Values.watchNamespaces }}
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- "*"
{{- end }}
Review Comment:
I don't completely understand this. Could we simply remove this entire if
logic? It seems that the required role is created later anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
