whjshj commented on PR #22648: URL: https://github.com/apache/flink/pull/22648#issuecomment-1562374590
> ## What is the purpose of the change > _(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)_ > > ## Brief change log > _(for example:)_ > > * _The TaskInfo is stored in the blob store on job creation time as a persistent artifact_ > * _Deployments RPC transmits only the blob storage reference_ > * _TaskManagers retrieve the TaskInfo from the blob cache_ > > ## Verifying this change > Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing > > _(Please pick either of the following options)_ > > This change is a trivial rework / code cleanup without any test coverage. > > _(or)_ > > This change is already covered by existing tests, such as _(please describe tests)_. > > _(or)_ > > This change added tests and can be verified as follows: > > _(example:)_ > > * _Added integration tests for end-to-end deployment with large payloads (100MB)_ > * _Extended integration test for recovery after master (JobManager) failure_ > * _Added test that validates that TaskInfo is transferred only once across recoveries_ > * _Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly._ > > ## Does this pull request potentially affect one of the following parts: > * Dependencies (does it add or upgrade a dependency): (yes / no) > * The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) > * The serializers: (yes / no / don't know) > * The runtime per-record code paths (performance sensitive): (yes / no / don't know) > * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) > * The S3 file system connector: (yes / no / don't know) > > ## Documentation > * Does this pull request introduce a new feature? (yes / no) > * If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
