hmedhat opened a new pull request, #22658:
URL: https://github.com/apache/flink/pull/22658

   What is the purpose of the change
   Setting different client ids for the consumer makes it difficult to set 
kafka quotas for that consumer group. Disabling setting consumer id prefix on 
the expense of kafka consumer metrics won't be reported correctly.
   
   Brief change log
   Allows setting client.id on the kafka consumer level which will ignore 
client.id.prefix being and will print a warning.
   
   Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   This change added tests and can be verified as follows:
   
   Manually verified the change a simple job and verified the client.id being 
set
   Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): (no)
   The public API, i.e., is any changed class annotated with @Public(Evolving): 
(no)
   The serializers: (no)
   The runtime per-record code paths (performance sensitive): (no)
   Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
   The S3 file system connector: (no )
   Documentation
   Does this pull request introduce a new feature? (no)
   If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to