tweise commented on code in PR #607:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/607#discussion_r1206092693
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/metrics/ScalingMetrics.java:
##########
@@ -82,7 +82,7 @@ public static void computeDataRateMetrics(
scalingMetrics.put(ScalingMetric.TRUE_PROCESSING_RATE,
trueProcessingRate);
scalingMetrics.put(ScalingMetric.CURRENT_PROCESSING_RATE,
numRecordsInPerSecond);
} else {
- LOG.error("Cannot compute true processing rate without
numRecordsInPerSecond");
+ LOG.warn("Cannot compute true processing rate without
numRecordsInPerSecond");
Review Comment:
Not actionable is also why I'm not sure about logging at warn level. Who is
going to read these logs? Will logs be flooded with repeating entries that are
unlikely to be addressed? I thought a message in the status (or one time event)
might be more useful, after all the application would need to be modified to
remedy the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
