Fanoid commented on PR #237: URL: https://github.com/apache/flink-ml/pull/237#issuecomment-1563914990
Hi, @zhipeng93 . As you have mentioned the proposed solution in this PR could be an alternative to implement GBDT in #210, can we make the target applications/scenarios clearer in the description of this PR? Many APIs/enums/codes in the infra codes are specifically designed/hard-coded for gradient-based algorithms, like `MessageType`, model format (`double[]`), `ModelUpdater`, codes in `ServerOperator`, etc. It is very difficult to extend current codes to support POJO messages and POJO model types unless developers make changes in the infra codes. If the PS infra is targeting to algorithms more than gradient-based algorithms, the infra APIs may need to reflect the considerations on those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
