xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1566386306
> > I think about it, the change of parallelism already exists in the existing unit test, I think we don't need to add the test, because it already includes the complete generated test case of the sequence. > > Thanks for pointing that out. I missed `DataGeneratorSourceTest`. Do you still see the value in having a `SequenceGeneratorTest` testing the basic functionality of the `SequenceGenerator`, though? It might help to understand the contract of the `SequenceGenerator` class. I don't think it is necessary to use `SequenceGeneratorTest` for testing, because the existing tests have covered its basic functions. Later, we may need to test how to avoid data skew and test sequence generation integrity when adjusting operator parallelism. @XComp WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
