Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1209923061
########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingCheckpointUtils.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.filemerging; + +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import javax.annotation.Nullable; + +import java.util.concurrent.Executor; +import java.util.concurrent.Executors; + +/** Utilities for file-merging checkpoints. */ +public class FileMergingCheckpointUtils { + + // ------------------------------------------------------------------------ + // FileMergingSnapshotManager initialization related + // ------------------------------------------------------------------------ + + /** A class that packs the file system info for snapshot. */ + public static class SnapshotFileSystemInfo { + FileSystem fs; + Path checkpointBaseDirectory; + Path sharedStateDirectory; + Path taskOwnedStateDirectory; + + public SnapshotFileSystemInfo( + FileSystem fs, + Path checkpointBaseDirectory, + @Nullable Path sharedStateDirectory, + Path taskOwnedStateDirectory) { + this.fs = fs; + this.checkpointBaseDirectory = checkpointBaseDirectory; + this.sharedStateDirectory = sharedStateDirectory; + this.taskOwnedStateDirectory = taskOwnedStateDirectory; + } + } + + public static SnapshotFileSystemInfo packFileSystemInfo( + FileSystem fs, + Path checkpointBaseDirectory, + Path sharedStateDirectory, + Path taskOwnedStateDirectory) { + return new SnapshotFileSystemInfo( + fs, checkpointBaseDirectory, sharedStateDirectory, taskOwnedStateDirectory); + } + + /** + * Create file-merging snapshot manager. + * + * <p>TODO (FLINK-32072): Create manager during the initialization of task manager services. + * + * @param id The id of this manager. Should be unique within job and be consistent after + * failover. + * @param asyncIO use async io to perform file system operation + * @return the created manager. + */ + public static FileMergingSnapshotManager createFileMergingSnapshotManager( + String id, boolean asyncIO) { + Executor ioExecutor = asyncIO ? Executors.newCachedThreadPool() : Runnable::run; Review Comment: I changed the logic here. Currently the builder of snapshot manager will receive a executor for IO, which is managed by someone outside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
