zentol commented on PR #22667: URL: https://github.com/apache/flink/pull/22667#issuecomment-1568436907
> => These are calls to ClosureCleaner, checkState and checkNotNull, VisibleForTesting which should be added as violation exceptions => The only discutable part is the dependency on org.apache.flink.core.memory.DataInputDeserializer and org.apache.flink.core.memory.DataOutputSerializer which are internal APIs but we could definitely use [ByteArray | Object]Streams JDK counterparts instead in the Cassandra code. I'd start a separate discussion on these. we likely want to make Preconditions/VisibleForTesting public. Not sure about `DataInput*`, maybe we can look at how it would look like in Cassandra and then make a call. ClosureCleaner I'm not sure about, but we could consider handling this internally in Flink instead of having each connector use it (e.g., call it in StreamExEnv#addSource) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
