eskabetxe commented on code in PR #49:
URL:
https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210527285
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java:
##########
@@ -322,6 +325,9 @@ void testBatchSink() throws Exception {
@Test
void testReadingFromChangelogSource() throws Exception {
+ if (!getMetadata().supportUpsert()) {
Review Comment:
the approach is fine, I only dont know if the name of method is the correct
(supportUpsert)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
