TanYuxin-tyx commented on code in PR #22652: URL: https://github.com/apache/flink/pull/22652#discussion_r1211220492
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SubpartitionSegmentIdTrackerImpl.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage; + +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.common.TieredStorageSubpartitionId; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierProducerAgent; +import org.apache.flink.util.function.SupplierWithException; + +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; + +/** + * The implementation of {@link SubpartitionSegmentIdTracker}. Each {@link TierProducerAgent} has a + * {@link SubpartitionSegmentIdTrackerImpl} to record the segments belong to the producer agent. + */ +public class SubpartitionSegmentIdTrackerImpl implements SubpartitionSegmentIdTracker { + + /** + * Each subpartition calculates the amount of data written to a tier separately. If the amount + * of data exceeds the threshold, the current writing segment will be finished. Because + * different subpartitions may have duplicate segment indexes, this field needs to distinguish + * between different subpartitions. + */ + private final Map<TieredStorageSubpartitionId, HashSet<Integer>> subpartitionSegmentIds; + + /** Indicate whether this is a broadcast only partition. */ + private final Boolean isBroadCastOnly; + + /** Record the latest segment index for each subpartition. */ + private final int[] latestSegmentIds; + + /** The locks for all subpartitions. */ + private final Lock[] locks; + + public SubpartitionSegmentIdTrackerImpl(int numSubpartitions, Boolean isBroadcastOnly) { + this.isBroadCastOnly = isBroadcastOnly; + int effectiveNumSubpartitions = isBroadcastOnly ? 1 : numSubpartitions; + this.latestSegmentIds = new int[effectiveNumSubpartitions]; + this.subpartitionSegmentIds = new HashMap<>(); + this.locks = new Lock[effectiveNumSubpartitions]; + + Arrays.fill(latestSegmentIds, -1); + for (int i = 0; i < effectiveNumSubpartitions; i++) { + locks[i] = new ReentrantLock(); + subpartitionSegmentIds.put(new TieredStorageSubpartitionId(i), new HashSet<>()); Review Comment: Based on the offline discussion, the segment tracker will be introduced in the subsequential PR. When introducing the segment tracker, this will be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
