rkhachatryan commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1212450869


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java:
##########
@@ -324,7 +325,7 @@ public void registerSharedStates(SharedStateRegistry 
stateRegistry, long checkpo
         for (Map.Entry<StateHandleID, StreamStateHandle> sharedStateHandle :
                 sharedState.entrySet()) {
             SharedStateRegistryKey registryKey =
-                    
createSharedStateRegistryKeyFromFileName(sharedStateHandle.getKey());
+                    createSharedStateRegistryKey(sharedStateHandle.getValue());

Review Comment:
   I rather see it as a part of this ticket because it's directly related and 
one should NOT be merged without the other.
   Why would you implement this as a separate ticket?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to