shuiqiangchen commented on code in PR #21927:
URL: https://github.com/apache/flink/pull/21927#discussion_r1212754824
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java:
##########
@@ -56,7 +56,7 @@ public RelDataType inferReturnType(SqlOperatorBinding
opBinding) {
List<RelDataType> types = new ArrayList<>();
for (int i = startTypeIdx; i < nOperands; i++) {
RelDataType type = opBinding.getOperandType(i);
- if (SqlTypeUtil.isNumeric(type)) {
+ if (SqlTypeUtil.isNumeric(type) || SqlTypeUtil.isCharacter(type)) {
Review Comment:
Yes, I would like to rename the class name to
LeastRestrictiveOrDefaultReturnTypeInference since numeric and character both
are types that have least restrictive. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
