[ 
https://issues.apache.org/jira/browse/FLINK-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604826#comment-15604826
 ] 

ASF GitHub Bot commented on FLINK-4733:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2616#discussion_r84867488
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobDetailsHandler.java
 ---
    @@ -147,11 +143,36 @@ public String handleRequest(ExecutionGraph graph, 
Map<String, String> params) th
                        }
                        gen.writeEndObject();
                        
    +                   long numBytesIn = 0;
    +                   long numBytesOut = 0;
    +                   long numRecordsIn = 0;
    +                   long numRecordsOut = 0;
    +
    +                   for (ExecutionVertex vertex : ejv.getTaskVertices()) {
    +                           IOMetrics ioMetrics = 
vertex.getCurrentExecutionAttempt().getIOMetrics();
    +
    +                           if (ioMetrics != null) { // execAttempt is 
already finished, use final metrics stored in ExecutionGraph
    +                                   numBytesIn += 
ioMetrics.getNumBytesInLocal() + ioMetrics.getNumBytesInRemote();
    --- End diff --
    
    That's a relic from the previous iterations, `getNumBytesInTotal()` did not 
always exist :)


> Port WebFrontend to new metric system
> -------------------------------------
>
>                 Key: FLINK-4733
>                 URL: https://issues.apache.org/jira/browse/FLINK-4733
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, TaskManager, Webfrontend
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
>
>
> While the WebFrontend has access to the metric system it still relies on 
> older code in some parts.
> The TaskManager metrics are still gathered using the Codahale library and 
> send with the heartbeats.
> Task related metrics (numRecordsIn etc) are still gathered using 
> accumulators, which are accessed through the execution graph.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to