WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1212845100
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/EndOfSegmentEvent.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.api; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.runtime.event.RuntimeEvent; + +import java.io.IOException; + +/** + * {@link EndOfSegmentEvent} is used to notify the downstream switch tiers in tiered storage shuffle + * mode. + */ +@Internal +public class EndOfSegmentEvent extends RuntimeEvent { + + /** The singleton instance of this event. */ + public static final EndOfSegmentEvent INSTANCE = new EndOfSegmentEvent(); + + @Override + public void write(DataOutputView out) throws IOException { + throw new UnsupportedOperationException("This method should never be called"); + } + + @Override + public void read(DataInputView in) throws IOException { + throw new UnsupportedOperationException("This method should never be called"); + } + + // ------------------------------------------------------------------------ + + @Override + public int hashCode() { Review Comment: Fixed. ########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyServiceWriter.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty; + +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty.impl.TieredStorageNettyServiceImpl; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.BufferContext; + +/** {@link NettyServiceWriter} is used to write buffers to {@link TieredStorageNettyServiceImpl}. */ +public interface NettyServiceWriter { + /** + * Write a buffer. + * + * @param bufferContext buffer context represents the buffer. + */ + void writeBuffer(BufferContext bufferContext); + + /** + * Get the number of existed buffers in the writer. + * + * @return the buffer number. + */ + int size(); + + /** Clear and recycle all existed buffers in the writer. */ Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
