[ 
https://issues.apache.org/jira/browse/FLINK-30751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang resolved FLINK-30751.
------------------------------
    Fix Version/s: 1.18.0
                   1.16.3
                   1.17.2
       Resolution: Fixed

merged in master: 581936f340a5aa7cfbf9166f2b1d0ad5ed457ce2, 
b232a7ebbe3fbf0c444fd0f48eaeafa0aa13a27a

release-1.17: cc8b37af7c2c20e20ec71eb6b87a0103041dfd3b, 
22696eec97e251d7b12dbbcc6530857643d322d2

release-1.16: b65b11bc9c87c489be0a514edd8c3290e090996c,
5c0108be3ae54bad5d7af8b8d4ed7ffac4bb8002

> Remove references to disableDataSync in RocksDB documentation
> -------------------------------------------------------------
>
>                 Key: FLINK-30751
>                 URL: https://issues.apache.org/jira/browse/FLINK-30751
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.16.0
>            Reporter: David Christle
>            Assignee: David Christle
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.18.0, 1.16.3, 1.17.2
>
>
> The EmbeddedRocksDBStateBackend allows configuration using some predefined 
> options via the .setPredefinedOptions method. The documentation for 
> PredefinedOptions 
> ([link|https://nightlies.apache.org/flink/flink-docs-master/api/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.html])
>  mentions disableDataSync is called for {{FLASH_SSD_OPTIMIZED}} and 
> {{{}SPINNING_DISK_OPTIMIZED{}}}.
>  
> But this option was removed several years ago in RocksDB 5.3.0 
> ([link|https://github.com/facebook/rocksdb/blob/main/HISTORY.md#530-2017-03-08]),
>  and according to the code 
> [PredefinedOptions.java|https://github.com/apache/flink/blob/0bbc7b1e9fed89b8c3e8ec67b7b0dad5999c2c01/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L72],
>  it is no longer actually set in Flink.
> We should remove references to disableDataSync in PredefinedOptions.java, and 
> in state_backend.py, so that it does not appear in the documentation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to