snuyanzin commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1218062955
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java: ########## @@ -0,0 +1,78 @@ +package org.apache.flink.connector.jdbc.dialect.clickhouse; + +import org.apache.flink.connector.jdbc.converter.AbstractJdbcRowConverter; +import org.apache.flink.connector.jdbc.dialect.AbstractDialect; +import org.apache.flink.connector.jdbc.internal.converter.ClickhouseRowConvert; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.RowType; + +import java.util.EnumSet; +import java.util.Optional; +import java.util.Set; + +/** */ Review Comment: well it's better to have some description about the class rather than an empty comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
