lincoln-lil opened a new pull request, #22715:
URL: https://github.com/apache/flink/pull/22715

   ## What is the purpose of the change
   The current `SqlCreateTableConverter` does not use the correct toString 
method when constructing column comments for `CatalogTable`, which may cause 
sql-client users and catalog implementers to encounter problems with Chinese 
characters in column comments not being displayed as expected.
   
   ## Brief change log
   update the toString logic for column comments in `SqlCreateTableConverter`
   
   ## Verifying this change
   Add Chinese characters in test cases of `SqlDdlToOperationConverterTest` 
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
@Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to