reswqa commented on code in PR #22714:
URL: https://github.com/apache/flink/pull/22714#discussion_r1218960419
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerConfigurationTest.java:
##########
@@ -65,8 +64,30 @@ public void testPreferLegacySlotRequestTimeout() throws
Exception {
final SlotManagerConfiguration slotManagerConfiguration =
SlotManagerConfiguration.fromConfiguration(configuration,
WorkerResourceSpec.ZERO);
- assertThat(
-
slotManagerConfiguration.getSlotRequestTimeout().toMilliseconds(),
- is(equalTo(legacySlotIdleTimeout)));
+ assertThat(legacySlotIdleTimeout)
+
.isEqualTo(slotManagerConfiguration.getSlotRequestTimeout().toMilliseconds());
+ }
+
+ @Test
+ void testComputeMaxTotalMemory() throws Exception {
Review Comment:
What does `test for rounding down division` mean? If it means that the
memory should be tested for not being divisible by `numSlots`, then
`MemorySize.ofMebiBytes(totalTaskManagerMB).getBytes()` here exactly cannot be
divided by `maxSlotNum `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
