zentol commented on code in PR #22667:
URL: https://github.com/apache/flink/pull/22667#discussion_r1219609586
##########
flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java:
##########
@@ -41,16 +39,14 @@ public class ConnectorRules {
"org.apache.flink.connector..",
"org.apache.flink.streaming.connectors.."
};
- private static DescribedPredicate<JavaClass>
areNotPublicAndResideOutsideOfPackages(
- String... packageIdentifiers) {
- return JavaClass.Predicates.resideOutsideOfPackages(packageIdentifiers)
- .and(
- not(areDirectlyAnnotatedWithAtLeastOneOf(
- Public.class, PublicEvolving.class))
- .and(not(modifier(PUBLIC))))
+ private static DescribedPredicate<JavaClass>
+
areFlinkClassesThatResideOutsideOfConnectorPackagesAndAreNotPublic() {
+ return JavaClass.Predicates.resideInAPackage("org.apache.flink..")
+
.and(JavaClass.Predicates.resideOutsideOfPackages(CONNECTOR_PACKAGES))
+ .and(not(areDirectlyAnnotatedWithAtLeastOneOf(Public.class,
PublicEvolving.class)))
Review Comment:
Like this maybe?
```
.and(
DescribedPredicate.not(
new DescribedPredicate<JavaClass>("") {
@Override
public boolean test(JavaClass javaClass)
{
if (!javaClass.isInnerClass()
||
!javaClass.getEnclosingClass().isPresent()) {
return true;
}
return
areDirectlyAnnotatedWithAtLeastOneOf(
Public.class,
PublicEvolving.class)
.test(javaClass.getEnclosingClass().get());
}
}))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
