WenDing-Y commented on code in PR #49:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1221506906


##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectTypeTest.java:
##########
@@ -0,0 +1,41 @@
+package org.apache.flink.connector.jdbc.databases.clickhouse.dialect;
+
+import org.apache.flink.connector.jdbc.dialect.JdbcDialectTypeTest;
+
+import java.util.Arrays;
+import java.util.List;
+
+/** The Clickhouse params for {@link JdbcDialectTypeTest}. */
+public class ClickHouseDialectTypeTest extends JdbcDialectTypeTest {
+
+    @Override
+    protected String testDialect() {
+        return "clickhouse";
+    }
+
+    @Override
+    protected List<TestItem> testData() {
+        return Arrays.asList(
+                createTestItem("CHAR"),

Review Comment:
   I tried to implement this function, when the data type is nested, array, and 
this object has uncertain data type information
   
   ```
    case ARRAY:
                   return new JdbcDeserializationConverter() {
                       @Override
                       public Object deserialize(Object jdbcField) throws 
SQLException {
                           return new GenericArrayData((Object[]) jdbcField);
                       }
                   };
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to