[
https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606152#comment-15606152
]
ASF GitHub Bot commented on FLINK-4879:
---------------------------------------
Github user hzyuemeng1 commented on the issue:
https://github.com/apache/flink/pull/2678
thanks for ur review,i am very interesting about Table SQL,and want to make
it better
2016-10-24
hzyuemeng1
发件人：Jark <[email protected]>
发送时间：2016-10-24 09:57
主题：Re: [apache/flink] [FLINK-4879] [Kafka-Connector] class KafkaTableSource
should be public just like KafkaTableSink (#2678)
收件人："apache/flink"<[email protected]>
抄送："hzyuemeng1"<[email protected]>,"Author"<[email protected]>
+1 to merge this. I think it's fine to make KafkaTableSource public, just
like FlinkKafkaConsumerBase.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
> class KafkaTableSource should be public just like KafkaTableSink
> ----------------------------------------------------------------
>
> Key: FLINK-4879
> URL: https://issues.apache.org/jira/browse/FLINK-4879
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector, Table API & SQL
> Affects Versions: 1.1.1, 1.1.3
> Reporter: yuemeng
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: 0001-class-KafkaTableSource-should-be-public.patch
>
>
> *class KafkaTableSource should be public just like KafkaTableSink,by
> default,it's modifier is default ，and we cann't access out of it's package*,
> for example:
> {code}
> def createKafkaTableSource(
> topic: String,
> properties: Properties,
> deserializationSchema: DeserializationSchema[Row],
> fieldsNames: Array[String],
> typeInfo: Array[TypeInformation[_]]): KafkaTableSource = {
> if (deserializationSchema != null) {
> new Kafka09TableSource(topic, properties, deserializationSchema,
> fieldsNames, typeInfo)
> } else {
> new Kafka09JsonTableSource(topic, properties, fieldsNames, typeInfo)
> }
> }
> {code}
> Because of the class KafkaTableSource modifier is default,we cann't define
> this function result type with KafkaTableSource ,we must give the specific
> type.
> if some other kafka source extends KafkaTableSource ,and we don't sure which
> subclass of KafkaTableSource should be use,how can we specific the type?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
