zentol commented on code in PR #21849:
URL: https://github.com/apache/flink/pull/21849#discussion_r1223032598
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -232,6 +233,27 @@ public void
testDuplicateJobSubmissionWithGloballyTerminatedAndCleanedJob() thro
assertDuplicateJobSubmission();
}
+ @Test
+ public void testDuplicateJobSubmissionIsDetected() throws Exception {
Review Comment:
There is not nice way to create a targeted test. Since we're starting out
from a state were _supposedly_ no JM termination future already exists there's
nothing to hook into.
You could maybe improve this a bit test my prepping 2 threads that each
waits on a OneShotLatch before submitting a job. You'd gain that both requests
are sent closer together.
You'd have to change the assertion though to check that _either_ job fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
