vahmed-hamdy commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1582688697
Hi @Samrat002 Great Work! thanks alot, the PR is in a good state IMO. I would add a test for the Factory class as well where we assert it creates catalog on happy case and test bunch of failure cases in validating the configs. I left some minor comments, once addressed please loop in @dannycranmer to have a final review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
