snuyanzin commented on code in PR #22624:
URL: https://github.com/apache/flink/pull/22624#discussion_r1223926176
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -556,7 +556,7 @@ object CodeGenUtils {
s"$rowTerm.setNullAt($indexTerm)"
}
- if (fieldType.isNullable) {
+ if (fieldType.isNullable ||
fieldExpr.nullTerm.startsWith("castRuleResultIsNull")) {
Review Comment:
IMHO it is not good to rely on var namings
rather it's better to check properties
why can't we pass a corresponding arg to
`org.apache.flink.table.planner.codegen.calls.ScalarOperatorGens$#generateCast`
for `nullOnFailure` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
