gyfora commented on code in PR #617:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1224109260
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -137,12 +138,13 @@ private Map<ScalingMetric, EvaluatedScalingMetric>
evaluateMetrics(
latestVertexMetrics.get(TRUE_PROCESSING_RATE),
getAverage(TRUE_PROCESSING_RATE, vertex,
metricsHistory)));
- evaluatedMetrics.put(
- PARALLELISM,
EvaluatedScalingMetric.of(topology.getParallelisms().get(vertex)));
+ var parallelism =
EvaluatedScalingMetric.of(topology.getParallelisms().get(vertex));
+ evaluatedMetrics.put(PARALLELISM, parallelism);
+ evaluatedMetrics.put(RECOMMENDED_PARALLELISM, parallelism);
Review Comment:
We could simply set this in the scaling executor only (but initialize to
null for the metric registration)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
