daniel-packard commented on PR #158:
URL: https://github.com/apache/flink-docker/pull/158#issuecomment-1584719615
@zentol - thanks for the detailed response!
I'll defer to you on the preferred way to handle this. I'm more comfortable
making the change here by adding symlinks, but I think updating
`docker-entrypoint.sh` to use `ls` instead of `[ -e ... ]` also makes sense -
I'm just less sure how to make that change 😅
something like this?
```sh
ls ${FLINK_HOME}/opt/${target_plugin}
if [ $? != 0 ]; then
# if return code of `ls <pattern>` is NON-zero, jar not found
echo "Plugin ${target_plugin} does not exist. Exiting."
exit 1
else
# if return code of `ls <pattern>` is zero, jar found -> symlink it
ln -fs "${FLINK_HOME}/opt/${target_plugin}"
"${FLINK_HOME}/plugins/${plugin_name}"
echo "Successfully enabled ${target_plugin}"
fi
```
Would there be an issue if _more than one_ file matched the regex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
