Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1227648014
########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.filemerging; + +import org.apache.flink.api.common.TaskInfo; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.runtime.state.CheckpointedStateScope; +import org.apache.flink.runtime.state.TaskStateManager; +import org.apache.flink.runtime.state.filesystem.FsCheckpointStorageAccess; + +import java.io.Closeable; + +/** + * FileMergingSnapshotManager provides an interface to manage files and meta information for + * checkpoint files with merging checkpoint files enabled. It manages the files for ONE single task + * in TM, including all subtasks of this single task that running in this TM. There is one + * FileMergingSnapshotManager for each task per task manager. + * + * <p>TODO (FLINK-32073): create output stream. + * + * <p>TODO (FLINK-32075): leverage checkpoint notification to delete logical files. + */ +public interface FileMergingSnapshotManager extends Closeable { Review Comment: Currently, it will not be called in different threads. The `#initFileSystem` will be called in the initialization of `FsCheckpointStorageAccess` and `StreamTask`. I think it's no need to clarify the thread-safety since it is not a tool class and will not be used everywhere. ########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.filemerging; + +import org.apache.flink.api.common.TaskInfo; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.runtime.state.CheckpointedStateScope; +import org.apache.flink.runtime.state.TaskStateManager; +import org.apache.flink.runtime.state.filesystem.FsCheckpointStorageAccess; + +import java.io.Closeable; + +/** + * FileMergingSnapshotManager provides an interface to manage files and meta information for + * checkpoint files with merging checkpoint files enabled. It manages the files for ONE single task + * in TM, including all subtasks of this single task that running in this TM. There is one + * FileMergingSnapshotManager for each task per task manager. + * + * <p>TODO (FLINK-32073): create output stream. + * + * <p>TODO (FLINK-32075): leverage checkpoint notification to delete logical files. + */ +public interface FileMergingSnapshotManager extends Closeable { Review Comment: Currently, it will not be called in different threads. The `#initFileSystem` will be called in the initialization of `FsCheckpointStorageAccess` and `StreamTask`. I think it's no need to clarify the thread-safety since it is not a tool class and will not be used everywhere. WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
